Update testcontainers to the newest version #4889
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Patrick Baumgartner <[email protected]> Signed-off-by: martinfrancois <[email protected]>
Co-authored-by: Patrick Baumgartner <[email protected]> Signed-off-by: martinfrancois <[email protected]>
| @@ -33,7 +33,7 @@ | |||
|
|
|||
| /** | |||
| * Official Docker images for Oracle are not publicly available. Oracle support is tested | |||
| * semi-manually for the moment: 1. Build a docker image for oracle/database:11.2.0.2-xe: | |||
| * semi-manually for the moment: 1. Build a docker image for gvenzl/oracle-free:23.7: | |||
There was a problem hiding this comment.
This is not an official docker image. I will omit that change on merge.
| @@ -47,7 +47,7 @@ | |||
| class OraclePagingQueryProviderIntegrationTests extends AbstractPagingQueryProviderIntegrationTests { | |||
|
|
|||
| // TODO find the best way to externalize and manage image versions | |||
| private static final DockerImageName ORACLE_IMAGE = DockerImageName.parse("oracle/database:11.2.0.2-xe"); | |||
| private static final DockerImageName ORACLE_IMAGE = DockerImageName.parse("gvenzl/oracle-free:23.7"); | |||
There was a problem hiding this comment.
same here, not an official image so we can't use it in Spring (Batch).
|
Rebased and merged as 584c3c6. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.